Test failures in TDVT were caused by unexpected order of operations.
For formula 86400 * x with x = TO_DAYS(date1) - TO_DAYS(date2) we get 86400 * TO_DAYS(date1) - TO_DAYS(date2) instead of 86400 * (TO_DAYS(date1) - TO_DAYS(date2)).
Brackets were added to function arguments for math operations in order to fix this issue.
Check List
[ ] New functionality includes testing.
[ ] All tests pass, including unit test, integration test and doctest
[ ] New functionality has been documented.
[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Description
Test failures in TDVT were caused by unexpected order of operations. For formula
86400 * xwithx = TO_DAYS(date1) - TO_DAYS(date2)we get86400 * TO_DAYS(date1) - TO_DAYS(date2)instead of86400 * (TO_DAYS(date1) - TO_DAYS(date2)).Brackets were added to function arguments for math operations in order to fix this issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.