opensearch-project / sql-odbc

OpenSearchODBC is a read-only ODBC driver for Windows and Mac for connecting to OpenSearch SQL support.
Apache License 2.0
7 stars 17 forks source link

Update third party notice. #46

Closed Yury-Fridlyand closed 1 year ago

Yury-Fridlyand commented 1 year ago

Description

In https://github.com/opensearch-project/sql/pull/479 ODBC driver was updated to use libcurl as a http transport library. Unfortunately, we missed to update 3rd party notice file. I added curl notice from https://github.com/curl/curl/blob/master/COPYING and removed PostgreS one, because there are no no postgres libs or dependencies. Perhaps it is a legacy part or copied by mistake from another driver.

Issues Resolved

N/A

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

GumpacG commented 1 year ago

Does src/CMakeLists.txt need to have a license header as well as per https://docs.oracle.com/cd/E37069_01/html/E37094/glpkn.html?

acarbonetto commented 1 year ago

Does src/CMakeLists.txt need to have a license header as well as per https://docs.oracle.com/cd/E37069_01/html/E37094/glpkn.html?

I don't think that's the cmake file generated by autoconf, nor are they makefiles. I think we're ok just to put it into the THIRD-PARTY.