search

opensearch-project / sql-odbc

OpenSearchODBC is a read-only ODBC driver for Windows and Mac for connecting to OpenSearch SQL support.
Apache License 2.0
7 stars 17 forks source link

[2.12.0] Ensure compatibility for 2.12.0 default admin credentials changes #65

Closed derek-ho closed 10 months ago

derek-ho commented 10 months ago

Is your feature request related to a problem? With the 2.12.0 release of OpenSearch, the security plugin's install demo configuration script requires an initial admin password to be passed in to run. We want to ensure all repos are aware/complaint with this change.

What solution would you like? A clear and concise description of what you want to happen.

What alternatives have you considered? A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context? Add any other context or screenshots about the feature request here.

derek-ho commented 10 months ago

Seems like tests are not being run: https://github.com/opensearch-project/sql-odbc/blob/cb5f4bd7ba4a15a2614ecbd3b53ddfcd9b4320fc/.github/workflows/sql-odbc-main.yml#L18, if maintainers have no objections I will close this issue out.

joshuali925 commented 10 months ago

https://github.com/opensearch-project/sql-odbc/blob/cb5f4bd7ba4a15a2614ecbd3b53ddfcd9b4320fc/src/IntegrationTests/ITODBCConnection/test_odbc_connection.cpp#L226-L244

this seems to be connecting using admin:admin, but i've not looked into odbc code before, checking with others

joshuali925 commented 10 months ago

closing since CI doesn't use security enabled cluster