opensearch-project / sql

Query your data using familiar SQL or intuitive Piped Processing Language (PPL)
https://opensearch.org/docs/latest/search-plugins/sql/index/
Apache License 2.0
121 stars 140 forks source link

Call updateState when query is cancelled #3139

Closed ykmr1224 closed 3 weeks ago

ykmr1224 commented 3 weeks ago

Description

Related Issues

3140 (This PR does not solve this issue)

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

noCharger commented 3 weeks ago

This does not affect the async-query behavior since AsyncQueryJobMetadata record does not store status yet

It makes me feel like this PR is a short term solution, is it an urgent change or we can go with longer term approach #3140?

ykmr1224 commented 3 weeks ago

This does not affect the async-query behavior since AsyncQueryJobMetadata record does not store status yet

It makes me feel like this PR is a short term solution, is it an urgent change or we can go with longer term approach #3140?

Yes, this is short term, but it does not have side effect. #3140 require much more effort and we don't have bandwidth right now.