Closed ykmr1224 closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.48%. Comparing base (
cfe38d7
) to head (dba09c4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
CI failure is due to coverage caused by: https://github.com/opensearch-project/sql/pull/3063
- Does the current class model meet the requirements for extending to another implementation?
Yes, DQS will internally check running jobs and limit new execution.
- Will this code change to BatchQueryHandler and RefreshQueryHandler affect the present logic of examining ConcurrentRefreshJobRule?
It won't affect. I excluded Batch query from ConcurrentRefreshJobRule.
Could you elaborate a little what was the issue?
DQS couldn't cover the Batch query to avoid too many concurrent execution.
Description
Related Issues
n/a
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.