opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch

Apache License 2.0

73 stars 56 forks source link

Fix error thrown when index configuration has no number_of_replicas specified #123

Closed rblcoder closed 9 months ago

rblcoder commented 9 months ago

Description

Fix error thrown when index configuration has no number_of_replicas specified

Issues Resolved

83 #108

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

rblcoder commented 9 months ago

@prudhvigodithi I have tested this PR with default values.

prudhvigodithi commented 9 months ago

Thanks @rblcoder so I assume it dint complain with the default values when executing tf apply?

prudhvigodithi commented 9 months ago

Also @rblcoder please try to add some unit tests to this change. Thanks

rblcoder commented 9 months ago

@prudhvigodithi Yes, it didn't complain with default values on re-apply. Added tests.

prudhvigodithi commented 9 months ago

Great, thanks @rblcoder, the PR LGTM.