search

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch
Apache License 2.0
73 stars 56 forks source link

fix: Missing cd in README.MD Running test locally #124

Open SkollRyu opened 9 months ago

SkollRyu commented 9 months ago

Description

./script/install-tools
export OSS_IMAGE="opensearchproject/opensearch:2"
docker-compose up -d
docker-compose ps -a
export OPENSEARCH_URL=http://admin:admin@localhost:9200
export TF_LOG=INFO
TF_ACC=1 go test ./... -v -parallel 20 -cover -short

In this original script, we run it when current directory is the root of repo. but it doesn't work for the last line of command go test because the current directory should be in provider/. So I add a line of cd command before the go test command line

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

prudhvigodithi commented 9 months ago

Thanks @SkollRyu can you also elaborate what does each step do for testing, so this way it would be easy for a new contributor to understand how the testing works. Example like 

Step 1: What its doing, purpose of this step

<command_used>

Step 2: What its doing, purpose of this step

<command_used>
SkollRyu commented 9 months ago

Thanks for your suggestion. @prudhvigodithi I have added line by line explanation.