search

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch
Apache License 2.0
73 stars 56 forks source link

Remove default creds #138

Closed derek-ho closed 5 months ago

derek-ho commented 8 months ago

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho commented 8 months ago

@peterzhuamazon @prudhvigodithi can you review this once? I am expecting CI to fail until after 2.12.0 docker image gets published, but looking for early feedback, or if you folks think this approach is appropriate - keep PR open until 2.12.0 image release, at which point CI would break and we merge in this PR to fix it. Not sure if I should modify provider_test.go.

derek-ho commented 7 months ago

Converting this to draft since it will not pass CI until after 2.12.0 release.

DarshitChanpura commented 6 months ago

@prudhvigodithi Now that 2.12 is released this should be unblocked. Would you mind bringing this home?

derek-ho commented 5 months ago

@prudhvigodithi I see you made a similar change recently, thanks for following up! I am closing this now since it is redundant.

prudhvigodithi commented 5 months ago

Thanks @derek-ho and @DarshitChanpura