Closed prudhvigodithi closed 1 year ago
Hey @phillbaker can you please help here, trying to update Masterminds/goutils to v1.1.1
, but go stuck in the dependency tree :(
The terraform-plugin-docs uses
github.com/Masterminds/goutils v1.1.1
and github.com/mitchellh/cli v1.1.4
so upgrading terraform-plugin-docs
plugin to latest version should upgrade to github.com/Masterminds/goutils v1.1.1
. But github.com/mitchellh/cli v1.1.4 is also dependent on github.com/Masterminds/sprig/v3 v3.2.0
, that actually uses github.com/Masterminds/goutils v1.1.0
, this was actually fixed in github.com/Masterminds/sprig/v3 v3.2.1
that was identified in github.com/mitchellh/cli v1.1.5, but the main and latest package terraform-plugin-docs
still uses github.com/mitchellh/cli v1.1.4
.
Any thoughts on how to move forward? or we should just wait until terraform-plugin-docs
uses github.com/mitchellh/cli v1.1.5
?
Thank you
@bbarani @peterzhuamazon
but the main and latest package terraform-plugin-docs still uses github.com/mitchellh/cli v1.1.4
It looks updated on main
: https://github.com/hashicorp/terraform-plugin-docs/blob/2c0ce1af2d6a0d034acfab45f61f87e7d87dbd94/go.mod#L12.
I'd vote to wait until it's released in 0.14.0 to avoid depending on unreleased changes.
Hey @phillbaker thanks for the looking into it, I will change back this to a draft PR.
Signed-off-by: Prudhvi Godithi pgodithi@amazon.com
Description
Update Masterminds/goutils to v1.1.1
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.