search

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch
Apache License 2.0
73 stars 56 forks source link

chore(docs): improve OpenSearch spelling #140

Closed etolbakov closed 8 months ago

etolbakov commented 8 months ago

Description

Renaming to address spelling issues with OpenSearch

Issues Resolved

https://github.com/opensearch-project/terraform-provider-opensearch/issues/139

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

etolbakov commented 8 months ago

Hello @dblock could you please take a look when you have time?

prudhvigodithi commented 8 months ago

Hey @etolbakov thanks for your contribution, I will very soon review this PR, thanks.

prudhvigodithi commented 8 months ago

LGTM!

etolbakov commented 8 months ago

Thank you @prudhvigodithi for a quick turnaround!

prudhvigodithi commented 8 months ago

@etolbakov can you please backport this to 1.x branch ?

etolbakov commented 8 months ago

Just to confirm by backport you mean applying the same set of changes to the 1.x branch right? If that's the case, sure will do that

prudhvigodithi commented 8 months ago

Yes you are right, update the same changes for 1.x branch.

etolbakov commented 8 months ago

Made the backport in https://github.com/opensearch-project/terraform-provider-opensearch/pull/141 @prudhvigodithi I see that tests have failed after the changes from current PR were merged in the main. Is there something I've overlooked?