search

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch
Apache License 2.0
73 stars 56 forks source link

Remove superfluous variable `flavor`. #147

Closed jk-senacor closed 7 months ago

jk-senacor commented 7 months ago

Description

The flavor variable inside of the getClient function is currently superfluous. If the value resolves to anything but opensearch, the function errors out, and all usages of flavor are after calling the getClient function.

This is especially problematic in combination with the opensearch_version provider variable, as setting this value (outside of serverless opensearch), causes the flavor variable to not be resolved, which in turn causes the function to always error out.

NOTE: I tried running the tfplugindocs generate command for the change in description of the tf provider variable, but if I made no mistake, then the master is currently dirty and generates multiple doc changes which have nothing to do with my pull request. I opted to not commit those changes, as it would muddy the PR.

Issues Resolved

https://github.com/opensearch-project/terraform-provider-opensearch/issues/36

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

necoras commented 5 months ago

Is there any movement on this? We're trying to rebuild a cluster and the terraform is failing to create any Open Search resources (indexes, index rollovers, etc.) with the error "opensearch version 2.9.0 is older than 6.0.0 and is not supported, flavor: 0."

It looks like this PR is intended to address that issue?