search

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch
Apache License 2.0
73 stars 56 forks source link

[FEATURE] Migrate to aws-sdk-go-v2 #151

Open jmaitrehenry opened 7 months ago

jmaitrehenry commented 7 months ago

Is your feature request related to a problem?

Actually, the aws-dsk-go is deprecated. Also, it contain security issue actually because of one of the dependency is not updated, so we could try to update the aws-sdk to fix the dependency or we could try to migrate to the new SDK.

What solution would you like?

I think, migrating to the new SDK is more futur proof, but, it require go 1.19 and this project use go 1.18. I don't know if it could be an issue to migrate to a newer version of go in the same time.

What alternatives have you considered?

Updating the current AWS SDK or inform the AWS SDK team of the issue.

Do you have any additional context?

Actually, I found the problem here: https://github.com/opensearch-project/terraform-provider-opensearch/pull/150/checks?check_run_id=20781305950

And the dependency issue come from golang.org/x/net@v0.17.0 which is required by github.com/aws/aws-sdk-go@v1.50.1

❯ go mod graph | grep golang.org/x/crypto@v0.14
golang.org/x/net@v0.17.0 golang.org/x/crypto@v0.14.0

❯ go mod graph | grep golang.org/x/net@v0.17.0
github.com/aws/aws-sdk-go@v1.50.1 golang.org/x/net@v0.17.0
prudhvigodithi commented 6 months ago

[Triage] Thanks @jmaitrehenry, can you please take a look and to see for upgrading to go 1.19? Thanks Adding @bbarani @rblcoder