fix example data in docs

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch

Apache License 2.0

73 stars 55 forks source link

fix example data in docs #166

Closed loru88 closed 4 months ago

loru88 commented 4 months ago

Description

some examples were based on legacy Elasticsearch version
switch to string instead of number to match the OpenSearch type
add deprecation message to opensearch_ism_policy_mapping

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

loru88 commented 4 months ago

partial duplicate of #165

Also it shows the same deprecation message in the documentation merged in #159

prudhvigodithi commented 4 months ago

Thanks @loru88 LGTM, @rblcoder can you please add your review as well?

rblcoder commented 4 months ago

@loru88 Few of the changes remain to be replicated in the tests as well. They are minor ones. Can you please change the corresponding tests as well?

loru88 commented 4 months ago

@loru88 Few of the changes remain to be replicated in the tests as well. They are minor ones. Can you please change the corresponding tests as well?

Thank you, I just fixed the issues. I updated the .go. files and I also fixed the OpenSearch spelling because it was only fixed in the generated file but it got reverted every time I run the command tfplugindocs.

loru88 commented 4 months ago

that's great, thank you @rblcoder . Can you approve the Workflow run, please?