Fix serverless authentication not working

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch

Apache License 2.0

73 stars 55 forks source link

Fix serverless authentication not working #180

Closed rblcoder closed 3 months ago

rblcoder commented 3 months ago

Description

Authentication for serverless has stopped working

Issues Resolved

Issue #179

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

rblcoder commented 3 months ago

@prudhvigodithi Have tested with both these provider configurations with AWS OpenSearch Serverless

provider "opensearch" {
  url = "url"
  healthcheck        = "false"
  aws_profile = "profilename"
  aws_assume_role_arn = "rolearn"
  aws_assume_role_external_id = "externalid"
  aws_region          = "region"
  version_ping_timeout = "10"

}

and

provider "opensearch" {
  url = "url"
  healthcheck        = "false"
  aws_region          = "region"
  aws_access_key = "access key"
  aws_secret_key = "secret"
  version_ping_timeout = "10"

}

prudhvigodithi commented 3 months ago

Had an offline discussion with @rblcoder and this code works, but however we should remove the osVersion info.Version.Number usages across the code as with branching and release of the terraform provider there is a compatibility matrix that will handle the right OpenSearch versions. https://github.com/opensearch-project/terraform-provider-opensearch/blob/main/COMPATIBILITY.md @bbarani