opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch
Apache License 2.0
74 stars 57 forks source link

add support for notification channels #68

Closed alexconlin closed 1 year ago

alexconlin commented 1 year ago

Signed-off-by: Alex Conlin-Oakley 458604+alexconlin@users.noreply.github.com

Description

Adds support for configuring channels in the OpenSearch notifications plugin.

Issues Resolved

Closes #30

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

prudhvigodithi commented 1 year ago

Thanks for the contribution @alexconlin, I will take a look at this PR and provide feedback shortly. Adding @bbarani @phillbaker @peterzhuamazon

prudhvigodithi commented 1 year ago

The test initially failed with error

  Running [/home/runner/golangci-lint-1.29.0-linux-amd64/golangci-lint run --out-format=github-actions --verbose --timeout=10m] in [] ...
  Error: File is not `gofmt`-ed with `-s` (gofmt)
  Error: File is not `gofmt`-ed with `-s` (gofmt)

@alexconlin can you run golangci-lint run --out-format=github-actions on your local to replicate the error? Thank you

alexconlin commented 1 year ago

@prudhvigodithi those errors should be fixed now. Please could you re-approve the test run?

prudhvigodithi commented 1 year ago

Thanks @alexconlin can you also run the https://github.com/hashicorp/terraform-plugin-docs, this should generate the resources and examples for this new notification support.

prudhvigodithi commented 1 year ago

LGTM, @alexconlin can you please generate the tfdocs? @phillbaker please take a look when you get a chance. Thank you

alexconlin commented 1 year ago

@prudhvigodithi I have updated the documentation with tfplugindocs.

I notice that the url parameter has moved from Required to Optional. It does that when I generate docs on the main branch as well. It seems to be related to this issue in terraform-plugin-docs.

shurkus commented 1 year ago

Any news?

bbarani commented 1 year ago

@phillbaker can you please take a look when you get a chance?