When the provider assumes a given role, don't use the default profile…

opensearch-project / terraform-provider-opensearch

https://registry.terraform.io/providers/opensearch-project/opensearch

Apache License 2.0

74 stars 57 forks source link

When the provider assumes a given role, don't use the default profile… #87

Closed massimob76 closed 10 months ago

massimob76 commented 11 months ago

… if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (#86)

Description

When aws_assume_role_arn is given but no aws_profile, it won't set the profile to default but it will let the aws-sdk-go library to find out the credentials using the default provider chain. When aws_assume_role_arn is given as well as aws_profile, it won't change its current behaviour and the aws-sdk-go library will use the given profile.

Issues Resolved

This will revolve issue #86

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

prudhvigodithi commented 11 months ago

Thanks @massimob76 this looks good, any unit tests can be added?

prudhvigodithi commented 11 months ago

Hey @massimob76 just following back, can you please add some unit tests so that we can move forward with this PR? Thank you

massimob76 commented 11 months ago

hi @prudhvigodithi I will try to add some unit tests this week, sorry I have been very busy lately.

massimob76 commented 10 months ago

Hi @prudhvigodithi, I have added some tests - that required a few changes:

added a mock server for intercepting the api call rather than the real AWS endpoint. Only during tests we use a mock server endpoint when calling awsSession, otherwise endpoint="" which will lead to aws-sdk-go to call its real endpoint.
swapped the test_aws_config with the test_aws_credentials since when running it locally if a credentials file exists it will have the priority over the test_aws_config fixture. But using test_aws_credentials instead will remove any interference from the local setup.

prudhvigodithi commented 10 months ago

Thanks @massimob76 for your contribution, merging the PR now.

andrejvanderzee commented 10 months ago

Any ETA on releasing this now that it is merged?

estebane-frb commented 10 months ago

Any chance this can be released soon? This has been a big blocker for us to be able to use the provider.

justinhauer commented 10 months ago

@prudhvigodithi can you give us any type of time frame when you think this will be released?

prudhvigodithi commented 10 months ago

Hey @estebane-frb @justinhauer I have an issue created for this purpose https://github.com/opensearch-project/terraform-provider-opensearch/issues/122, I'm planning to go ahead with the release tomorrow (PST), just waiting on one feature PR to support OpenSearch serverless to go in https://github.com/opensearch-project/terraform-provider-opensearch/pull/92, thank you for your patience. Adding @vasyaxparfenov @bbarani

prudhvigodithi commented 10 months ago

The provider v2.1.0 has been released, please check. Provider Download link: https://registry.terraform.io/providers/opensearch-project/opensearch/2.1.0