search

opensearch-project / user-behavior-insights

User Behavior Insights plugin for OpenSearch
Apache License 2.0
17 stars 2 forks source link

Reference released version #13

Closed epugh closed 2 months ago

epugh commented 3 months ago

Description

UBI 1.0.0 has been released, update the README

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jzonthemtn commented 3 months ago

@epugh Sign your commits! :) :)

epugh commented 3 months ago

@jzonthemtn I may need some help on signing.. I was hoping to "amend" my last commit, but doesn't seem to be doing anything...

msfroh commented 3 months ago

@jzonthemtn I may need some help on signing.. I was hoping to "amend" my last commit, but doesn't seem to be doing anything...

I recently moved from developing on my EC2 instance to developing on my laptop (because latency to the EC2 instance from my hotel in Berlin a couple of weeks ago was terrible), so I had to relearn all the code signing tricks.

What I did after pushing an unsigned commit was:

export GPG_TTY=$(tty)         # Required to let the curses-based passkey prompt show up
git commit --amend -S         # -S to sign the commit
git push -f origin            # Update my PR

Before running export GPG_TTY=$(tty), the git commit --amend -S would fail, saying that it wasn't able to unlock my GPG key.

Then to fix things more permanently, I added that export GPG_TTY=$(tty) to my .zshrc, and ran git config --global commit.gpgsign true, so it always tries to sign my commits.

jzonthemtn commented 2 months ago

Closing in favor of #17