Open willscott opened 9 years ago
I'm leaving this here because it's relevant. https://github.com/jakubdostal/leaflet-geoip
GeoIP Plugin for Leaflet.js. This plugin allows you to find the approximate position of the client machine based on their IP address. Additionally, you can center the map on this location.
If the user gives up geolocation info, we should put a "you are here" marker on the map with that info.
http://leafletjs.com/plugins.html#geolocation
Also interesting would be to put a polygon saying "by your IP you are in this area". Dunno.
The basic "you are here marker" is in the mix. See #74
The GeoIP Plugin for Leaflet.j is still based on info from maxmind db, which is what mLab is using. I'd prefer not to do any further integrations with the maxmind dataset.
That was added simply to show something in the UI. Why do we not like integrating with the maxmind dataset? I was hoping this was just going to be a one-liner.
https://github.com/codeforseattle/seanetmap/wiki/Back-end#lookup-service-provider-based-on-client-ip
BTW, maxmind is already in the mix. I checked it into package.json a few days ago. I am going to check in the rest of it (all 10 lines about) so you can see just how much it isn't to be used. It really just provides a label to put in the UI, no backend integration.
Currently, tests would only record IP. they should also ask for browser's understanding of it's location, and metadata we ask for including: