search

opensemanticsearch / open-semantic-search-apps

Python/Django based webapps and web user interfaces for search, structure (meta data management like thesaurus, ontologies, annotations and named entities) and data import (ETL like text extraction, OCR and crawling filesystems or websites)
https://opensemanticsearch.org/
GNU General Public License v3.0
95 stars 36 forks source link

removed (I think) unused and un-needed code #33

Closed bhelou closed 6 years ago

bhelou commented 6 years ago

It didn't seem to me that the code below does anything.

# An empty list file for a facet won't cause error opening/reading it, even if no entry exists
list = open(tmplistfilename, 'a')
list.close()

Is it to create the file tmplistfilename if it does not exist? But tmplistfilename is set to ontology_tagger.labels_configfile = tmplistfilename and then in solr_ontology_tagger when labels_configfile is appended it is first opened:

labels_file = open(self.labels_configfile, 'a', encoding="utf-8")

(sorry if this is an insignificant and possibly wrong pull request ... this is my first pull request ever ... I am still learning the ropes and gotta start with small steps hehe)