Using DataEvent with an array of DataBlocks breaks SOS JSON clients

opensensorhub / osh-core

OpenSensorHub Core Modules

http://docs.opensensorhub.org

Mozilla Public License 2.0

32 stars 16 forks source link

Using DataEvent with an array of DataBlocks breaks SOS JSON clients #179

Closed csdillard closed 3 years ago

csdillard commented 3 years ago

If a sensor publishes a DataEvent with more than one DataBlock record, then a websocket client subscribed to SOS JSON will receive messages that have multiple JSON objects concatenated together (no separator, and no wrapping array). Currently the osh-js toolkit fails to parse this.

Perhaps the server should send each DataBlock as a separate websocket message.

csdillard commented 3 years ago

Commit ee735e3 appears to have already fixed this issue.