search

opensergo / opensergo-control-plane

Universal cloud-native microservice governance control plane (微服务治理控制面)
Apache License 2.0
35 stars 23 forks source link

Add support for traffic-routing spec v1alpha1 #32

Closed 123liuziming closed 1 year ago

123liuziming commented 1 year ago

Describe what this PR does / why we need it

We can observe the label routing crd provided by OpenSergo, and publish it to SDK

Does this pull request fix one issue?

Fixes #33

Describe how you did it

see #33

Describe how to verify it

Special notes for reviews

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

123liuziming commented 1 year ago

Could you please add an issue for this PR, and add some description of your design and implementation in this PR description

done

jnan806 commented 1 year ago

rename config/samples/istio_viretual_service_samples.yaml with opensergo is better.

pkg/controller/crd_transform.go is only used for traffic, better to indicate it in the file name.

123liuziming commented 1 year ago

rename config/samples/istio_viretual_service_samples.yaml with opensergo is better.

pkg/controller/crd_transform.go is only used for traffic, better to indicate it in the file name.

Thanks! I will fix them.

123liuziming commented 1 year ago

I 've fixed the questions above. Thanks！

sczyh30 commented 1 year ago

The CI lint failure might be caused by low version of the linter. I'll fix it later.

sczyh30 commented 1 year ago

cc @jnan806 @123liuziming @panxiaojun233 I'll use "squash and merge" for this PR to keep our commits tidy.

sczyh30 commented 1 year ago

Nice work. Thanks for contributing!