openservicebrokerapi / osb-checker

An automatic checker to verify an Open Service Broker API implementation against the specification
https://github.com/openservicebrokerapi/servicebroker/
Apache License 2.0
48 stars 40 forks source link

Send operation data when polling last_operation after provision #32

Closed nodo closed 5 years ago

nodo commented 6 years ago

Similarly to what we have done in https://github.com/openservicebrokerapi/osb-checker/pull/25/files, we need to pass operation query params when polling last_operation during provision

Signed-off-by: Andrea Nodari anodari@pivotal.io

cfdreddbot commented 6 years ago

Hey nodo!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

mattmcneeney commented 6 years ago

LGTM

@duglin for the other one?

Approved with PullApprove

nodo commented 6 years ago

Hey @mattmcneeney @duglin , I have just noticed that this PR is pending for a while? do you have any updates on this? Is there anything I can do to speed up the process?

leonwanghui commented 6 years ago

+1

mattmcneeney commented 6 years ago

@openservicebrokerapi/osbapi-pmc one more LGTM needed please!

mattmcneeney commented 6 years ago

Sorry for the delay @nodo

zhongyi-zhang commented 6 years ago

This is a nice TODO item I commented in the test framework. I'll help rebase and resolve conflicts.

zhongyi-zhang commented 6 years ago

Rebase on the change in https://github.com/openservicebrokerapi/osb-checker/pull/39. @leonwanghui @norshtein could you have a review?

norshtein commented 5 years ago

LGTM

Approved with PullApprove