openservicebrokerapi / osb-checker

An automatic checker to verify an Open Service Broker API implementation against the specification
https://github.com/openservicebrokerapi/servicebroker/
Apache License 2.0
48 stars 40 forks source link

Add Dockerfile for building test environment #37

Closed leonwanghui closed 5 years ago

leonwanghui commented 6 years ago

Signed-off-by: leonwanghui wanghui71leon@gmail.com

Introduction

This patch mainly focuses on solving the issue #31

How to build mock-broker and test-job docker image

These commands below present how to building test environment:

make docker

After this finished, you will find two docker images created:

root@vultr:~/workspace/osb-checker# docker images
REPOSITORY                         TAG                 IMAGE ID            CREATED             SIZE
osb-checker/test-job               2.13                bd833779fd29        6 seconds ago       676MB
osb-checker/mock-broker            2.13                deb24670b84c        10 seconds ago      672MB

How to run these two docker images

docker run -d --net=host osb-checker/mock-broker:2.13
docker run -it --net=host osb-checker/test-job:2.13
cfdreddbot commented 6 years ago

Hey leonwanghui!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

norshtein commented 5 years ago

The PR mostly LGTM. One thing is, better to create a doc and add the description about how to use the docker image to the doc.

Approved with PullApprove

zhongyi-zhang commented 5 years ago

I think the CI should be updated, too.

norshtein commented 5 years ago

LGTM

Approved with PullApprove