openservicebrokerapi / osb-checker

An automatic checker to verify an Open Service Broker API implementation against the specification
https://github.com/openservicebrokerapi/servicebroker/
Apache License 2.0
48 stars 40 forks source link

Add eslint and fix lint issue for the mock server #60

Closed zhongyi-zhang closed 5 years ago

zhongyi-zhang commented 5 years ago

Solve https://github.com/openservicebrokerapi/osb-checker/issues/56 for the mock server. I'll solve it for the test framework and create another PR.

cfdreddbot commented 5 years ago

:white_check_mark: Hey zhongyi-zhang! The commit authors and yourself have already signed the CLA.

zhongyi-zhang commented 5 years ago

@leonwanghui see the change in 2.13/mocks/package.json. You can run npm -s run-script eslint or simplely npm test before submiting a PR to ensure it returns no errors or warnings. It is also included in the CI.

leonwanghui commented 5 years ago

Cool!

norshtein commented 5 years ago

LGTM

Approved with PullApprove