Make schema extensible and flexible

openservicebrokerapi / osb-checker

An automatic checker to verify an Open Service Broker API implementation against the specification

https://github.com/openservicebrokerapi/servicebroker/

Apache License 2.0

48 stars 40 forks source link

Make schema extensible and flexible #61

Closed leonwanghui closed 5 years ago

leonwanghui commented 5 years ago

For broker implementation of some service providers, they have enhanced some features by adding some additional fields in the schema. But currently validateJSONSchema method doesn't work because the definition of schema is fixed, so this patch is proposed to make schema more flexible so that service providers can implement some advanced features at the same time passing validation check.

cfdreddbot commented 5 years ago

:white_check_mark: Hey leonwanghui! The commit authors and yourself have already signed the CLA.

norshtein commented 5 years ago

Additional fields is enabled in v2.14: https://github.com/openservicebrokerapi/servicebroker/blob/v2.14/spec.md#vendor-extension-fields https://github.com/openservicebrokerapi/servicebroker/blob/v2.14/spec.md#changes-since-v213 https://github.com/openservicebrokerapi/servicebroker/pull/436

So v2.13 checker shouldn't contain this PR. You may want to create a new folder 2.14 and apply the PR to 2.14

leonwanghui commented 5 years ago

Thanks, will close it for now