Adjustments according to the version 2.14 specs.

[mrgunior]

This branch has been merged with the following branches:

• testfix-update
• testfix-provision
• testfix-deprovision
• testfix-unbind
• testfix-binding
• tesfix-provision-poll

if you would prefer to have separate PRs let me know, I can create them.

Changes with binding.go:

• when binding it is required to have service_id and plan_id. This was not the case in the test case, and cause the test to fail. To fix this tempBody was added, and openapi.ServiceBindingRequest{} removed. The test case now works as described by the specs.

Changes with common.go:

• when polling last operation provisioning, deprovisioning or binding. The operation query string field must be included for async operations. Hence why I added it, and also changed the functions to be able to accept an extra parameter to pass the operation string dynamically when doing a GET request for the last operation poll.

Changes with deprovision.go:

• when deprovisioning it is required to have service_id and plan_id. This was not the case in the test case, and cause the test to fail. To fix this tempBody was added, and openapi.ServiceBindingRequest{} removed. The test case now works as described by the specs

Changes with provision.go:

• when provisioning it is required to have service_id and plan_id. This was not the case in the test case, and cause the test to fail. To fix this tempBody was added, and openapi.ServiceBindingRequest{} removed. The test case now works as described by the specs.
• Added an extra string parameter for the operation when doing a GET request for polling the last operation for service instances. When a value for operation is included with asynchronous responses for Provision, Update, and Deprovision requests, the Platform MUST provide the same value using this query parameter as a percent-encoded string. If present, MUST be a non-empty string.

Changes with update_instance.go:

• when updating an instance it is required to have service_id. This was not the case in the test case, and cause the test to fail. To fix this tempBody was added, and openapi.ServiceBindingRequest{} removed. The test case now works as described by the specs. I left plan_id in the request, seeing it is optional. Keeps the code similar to the others.
• Added an extra string parameter for the operation when doing a GET request for polling the last operation for service instances. When a value for operation is included with asynchronous responses for Provision, Update, and Deprovision requests, the Platform MUST provide the same value using this query parameter as a percent-encoded string. If present, MUST be a non-empty string.

Changes with lifecycle.go:

• Removed variable currentPlanID from switch cases.
• Added extra parameter to the pollLastOperationStatus function that in turn when called by either privision or binding, is able to re-use the same function. Now with this change you only need to pass as a string "update", "provision", and "deprovision" from the testcase calling it. Operation is required according to the specs.
• I added the required operation strings "update", "provision", and "deprovision" in their respective modules.

changes with config_mock.yaml:

• Added plan_id to operationa type bind as described by binding.
• Added plan_id to operation type unbind as described by unbinding
• Added plan_id to operation type deprovision as described by deprovisioning.

[cfdreddbot]

:white_check_mark: Hey mrgunior! The commit authors and yourself have already signed the CLA.

[leonwanghui]

It seems that the ci doesn't work any more, could u please take a look?

[mrgunior]

Changes are done. I also noticed that when running the make command for deploying and using this mock broker. It actually creates the osbchecker.mockbroker in ./build/bin/ instead of ./build/ in the README.md.

[leonwanghui]

@mrgunior Got it, I will pull a PR to fix that.