openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

dashboard_url and asynchronous provisioning #170

Closed luksa closed 6 years ago

luksa commented 7 years ago

The spec requires the broker to return the dashboard_url immediately, even when it uses asynchronous provisioning. What if the URL isn't know at that point? There's currently no way to return it later.

avade commented 7 years ago

Have you got a use case at the moment of when the URL couldn't be predicted in advance? I can imagine use cases for this, but I haven't come across a solid need yet.

In Pivotal services, we often use the Go Router to handle dashboard routes and place them on a system domain, and these can be reserved in advance.

pmorie commented 7 years ago

Regardless of where we settle on this, we should make the spec clearer about it.

On Thu, Apr 27, 2017 at 10:12 AM, Alex Ley notifications@github.com wrote:

Have you got a use case at the moment of when the URL couldn't be predicted in advance? I can imagine use cases for this, but I haven't come across a solid need yet.

In Pivotal services, we often use the Go Router to handle dashboard routes and place them on a system domain, and these can be reserved in advance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openservicebrokerapi/servicebroker/issues/170#issuecomment-297725213, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWXmI1f7Mv2nE0ceWI6pHwtZRj-C3_kks5r0KJLgaJpZM4NKGlC .

avade commented 7 years ago

Agree we should call out that this is the ONLY chance to return dashboard URL. Want to make the PR?

pmorie commented 7 years ago

I'd be happy to make the PR once we sort out what @luksa needs to do

luksa commented 7 years ago

Nevermind. I thought I couldn't get the URL at that point yet. Turns out I can.

+1 on stating explicitly that's when the broker must return the URL

pmorie commented 7 years ago

Cool, I'll cut a PR for this momentarily.

bmelville commented 7 years ago

I think this issue remains, as in some services, the URL contains dynamically provisioned IP addresses or ports, which are not known until some time in the async process (e.g., provisioning wordpress instances, kubernetes clusters, etc. will need to provision an IP address before knowing the dashboard_url).

mattmcneeney commented 6 years ago

The spec now allows the dashboard_url to be fetched in the GET service instances endpoint, so this can be closed.