openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

Add warning text about using weird chars in IDs #299

Closed duglin closed 7 years ago

duglin commented 7 years ago

Closes #273

Signed-off-by: Doug Davis dug@us.ibm.com

cfdreddbot commented 7 years ago

Hey duglin!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

angarg12 commented 7 years ago

LGTM

Approved with PullApprove

mattmcneeney commented 7 years ago

LGTM. Nice one.

Approved with PullApprove

avade commented 7 years ago

I like the way that you have explained WHY by stating the properties are used in URLs

LGTM

Approved with PullApprove

duglin commented 7 years ago

Addressed @mhbauer's minor URL comment. Another round of reviews needed.

angarg12 commented 7 years ago

LGTM

Approved with PullApprove

mattmcneeney commented 7 years ago

LGTM

Approved with PullApprove

duglin commented 7 years ago

2 more reviews needed

vaikas commented 7 years ago

LGTM

Approved with PullApprove

avade commented 7 years ago

lgtm

Approved with PullApprove

angarg12 commented 7 years ago

LGTM

Approved with PullApprove

shalako commented 7 years ago

LGTM

Approved with PullApprove