Closed n3wscott closed 7 years ago
Hey n3wscott!
Thanks for submitting this pull request!
All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).
When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.
If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.
Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.
Hey n3wscott!
Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
hmm @mattmcneeney shouldn't those links be good now?
@duglin yes they should. I think the problem may be that this branch needs to be rebased on master?
Ok let me try to rebase.
I think I had rebased already but I had not pushed my local master to github. Done now.
Looks like it's going to pass this time :)
Reading the spec for the first time, these jumped out as minor mistakes.