openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

Clarify how to clean-up during a failed provision/bind #353

Closed duglin closed 7 years ago

duglin commented 7 years ago

Closes #348

We actually already had text to deal with this in the bind() case, it was just missing the MUST, so I added that and then copied that same text into the provision case.

Net: platforms MUST send a DELETE to the brokers upon a failed provison/bind just to make sure things are cleaned up.

I'll open a 2nd PR to add text talking about how the brokers SHOULD clean-up on their own w/o the need for the DELETE.

Signed-off-by: Doug Davis dug@us.ibm.com

cfdreddbot commented 7 years ago

Hey duglin!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

duglin commented 7 years ago

Change it from SHOULD to MUST so brokers will know what to expect.

avade commented 7 years ago

LGTM

Approved with PullApprove

mattmcneeney commented 7 years ago

LGTM 👏

Approved with PullApprove

angarg12 commented 7 years ago

LGTM

Approved with PullApprove

vaikas commented 7 years ago

LGTM

Approved with PullApprove

pmorie commented 7 years ago

LGTM

Approved with PullApprove

avade commented 7 years ago

LGTM

Approved with PullApprove

duglin commented 7 years ago

One more review needed

mattmcneeney commented 7 years ago

LGTM

Approved with PullApprove