Allow periods in the name field

[mihnjong]

Service class and plan names can contain periods (".").

closes: #442

[cfdreddbot]

Hey mihnjong!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

[duglin]

removing L GTM due to CLA not being there. @mihnjong can you sign the CLA?

[mihnjong]

For this change, I worked as a Google employee. which form should I sign?

[duglin]

@chipchilders can you answer @mihnjong's question? I'm not familiar enough with the CLA process.

[chipchilders]

@mihnjong you need to be a publicly listed member of the GoogleCloudPlatform GH org for the Google CLA to cover your contribution. That's the GH org that Google identified as the right org for us to use in the bot. Alternatively you can follow the ICLA instructions to sign as yourself (which assumes you have your employer's permission to do so).

[cfdreddbot]

Hey mihnjong!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

[mihnjong]

@n3wscott helped me to make visible my organization status. I guess the PR is good to go now :)

[chipchilders]

close / open to kick the bot

[chipchilders]

close / open to kick the bot

[cfdreddbot]

Hey mihnjong!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

[chipchilders]

@mihnjong still not publicly listing you as part of the GoogleCloudPlatform GH org. I only see the Google GH org in your profile.

[cfdreddbot]

Hey mihnjong!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

[n3wscott]

LGTM

[duglin]

LGTM

[duglin]

2 more needed

[fmui]

LGTM

[mattmcneeney]

LGTM but conflicts need fixing @mihnjong

[duglin]

@mihnjong can you rebase to fix the conflict?

[subhankarc]

Hi,

Will this improvement be part of v2.13? Eagerly waiting for it. We also have a similar use-case where plan names contain version number which includes periods.

Regards, Subhankar

[duglin]

@mihnjong can you rebase please?

@subhankarc I expect it to be part of v2.13 but when it will appear in Kube and CF is up to those projects. Once approved, I think Kube should be able to add it within days, but I can't speak for CF. @mattmcneeney

[duglin]

@mihnjong I did the rebase for you - hope that's ok

[duglin]

LGTM

3 more reviews needed

[n3wscott]

LGTM

[fmui]

LGTM

[vaikas]

LGTM

[mihnjong]

Sorry.. I was swamped with other work. Thanks @duglin !