Add a `clusterID` to the profile for kube

openservicebrokerapi / servicebroker

Open Service Broker API Specification

https://openservicebrokerapi.org/

Apache License 2.0

1.19k stars 434 forks source link

Add a `clusterID` to the profile for kube #466

Closed duglin closed 6 years ago

duglin commented 6 years ago

ping @pmorie - see if this aligns with what we talked about today.

Signed-off-by: Doug Davis dug@us.ibm.com

cfdreddbot commented 6 years ago

Hey duglin!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

n3wscott commented 6 years ago

LGTM

duglin commented 6 years ago

Need re-reviews due to new commit

duglin commented 6 years ago

@n3wscott can you review again - it doesn't seem to have picked yours up. Also, we need 3 more reviews.

n3wscott commented 6 years ago

LGTM

...robots.

n3wscott commented 6 years ago

it doesn't seem to have picked yours up.

I wonder if the issue is because that was not a generic top level PR comment but a end of review comment... I bet that is the issue.

avade commented 6 years ago

LGTM - we should look at adding the "WHY" this field is important or use cases.

cfdreddbot commented 6 years ago

Hey duglin!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

duglin commented 6 years ago

not sure what's going on, but @avade and @n3wscott can you guys re LGT M ?