search

openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

What does plan_updateable apply to? #491

Closed duglin closed 6 years ago

duglin commented 6 years ago

See: https://github.com/kubernetes-incubator/service-catalog/issues/1906

Does it just control whether you can change the "plan" or does it also indicate whether you can update the existing Instance's parameters (w/o changing the plan)?

We should clarify this in the spec.

/cc @luksa

Samze commented 6 years ago

In Cloud Foundry plan_updateable controls the switching of plans and does not affect updating a service instance's parameters. I believe this is why it is attached to the service object and not the plan object.

I agree this is confusing.

n3wscott commented 6 years ago

@Samze That is how I was understanding the property too.

mattmcneeney commented 6 years ago

It doesn't look like there is anything else to do here, so I'll close it. Please re-open if I'm mistaken.

luksa commented 6 years ago

I've revisited this and there is something else to do. The spec specifically says that if plan_updateable is false, the platform is not allowed to update the service instance at all:

If "plan_updateable": true is declared for a plan in the Catalog endpoint, the Platform MAY request an update of a Service Instance using the given plan. Otherwise, Platforms MUST NOT make an update request to the Service Broker for any Service Instance using the given plan.

I've submitted a PR that clarifies this: #519