Clarify contributing process - Githubissues

openservicebrokerapi / servicebroker

Open Service Broker API Specification

https://openservicebrokerapi.org/

Apache License 2.0

1.19k stars 434 forks source link

Clarify contributing process #494

Closed mattmcneeney closed 6 years ago

cfdreddbot commented 6 years ago

Hey mattmcneeney!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

duglin commented 6 years ago

LGTM

duglin commented 6 years ago

2 more reviews needed

duglin commented 6 years ago

@mattmcneeney did you want to address the comments on this?

duglin commented 6 years ago

@mattmcneeney did you want to address the comments on this?

mattmcneeney commented 6 years ago

@duglin I think the only actionable thing was to break up a wall of text which I think we could do later / if we get feedback that the guide is hard to follow. WDYT?

duglin commented 6 years ago

that's fine with me. @pmorie you ok with that?

duglin commented 6 years ago

Needs 2 more reviews - I think we can deal with the "split" in a follow-on PR if needed. ping @fmui @kibbles-n-bytes @vaikas-google @zrob

zrob commented 6 years ago

lgtm

fmui commented 6 years ago

LGTM