openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

Remove version-specific text from the specification #521

Closed mattmcneeney closed 6 years ago

mattmcneeney commented 6 years ago

The specification is versioned, so I don't believe we need this bit of text referring to a specific version of the spec supporting a new feature.

cfdreddbot commented 6 years ago

Hey mattmcneeney!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

mattmcneeney commented 6 years ago

cc @duglin @n3wscott following yesterday's call

duglin commented 6 years ago

@mattmcneeney I think finding a way to drop the version string is ok, but this proposal drops the requirement that the Platform MUST detect the new value and use it going forward. Or are you thinking that its not required because its obvious?

mattmcneeney commented 6 years ago

@duglin exactly. For provision, we don't say that Platforms MUST use the dashboard_url that is returned, so I wasn't sure why we would say so here!

duglin commented 6 years ago

@mattmcneeney ok I can buy into that

duglin commented 6 years ago

LGTM

Approved with PullApprove

fmui commented 6 years ago

LGTM

Approved with PullApprove

duglin commented 6 years ago

Just one more review needed

zrob commented 6 years ago

lgtm

Approved with PullApprove