openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

Clarify platform behavior when dashboard url is not returned #527

Closed tinygrasshopper closed 6 years ago

tinygrasshopper commented 6 years ago

while polling on update.

Have not expressed an opinion on how the broker can clear out an existing dashboard url, but clarified current behaviour in a way that its backwards compatible.

cfdreddbot commented 6 years ago

Hey tinygrasshopper!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

pmorie commented 6 years ago

One minor nit - there's a misspelling in the commit message ('clarify')

duglin commented 6 years ago

rebase needed

duglin commented 6 years ago

SGTM just waiting for the rebase

mattmcneeney commented 6 years ago

@tinygrasshopper We discussed this on today's call and are happy to start reviewing, but it needs a rebase first!

tinygrasshopper commented 6 years ago

@mattmcneeney rebased

duglin commented 6 years ago

LGTM

Approved with PullApprove