Closed tinygrasshopper closed 6 years ago
Hey tinygrasshopper!
Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
One minor nit - there's a misspelling in the commit message ('clarify')
rebase needed
SGTM just waiting for the rebase
@tinygrasshopper We discussed this on today's call and are happy to start reviewing, but it needs a rebase first!
@mattmcneeney rebased
while polling on update.
Have not expressed an opinion on how the broker can clear out an existing dashboard url, but clarified current behaviour in a way that its backwards compatible.