openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

Make identity header naming consistent #535

Closed williammartin closed 6 years ago

williammartin commented 6 years ago

Another small fixup around the Originating-Identity header. Might seem trivial but as I got to this section I wasn't initially sure which was the "correct" version, until I got to later sections where the hyphen is repeated. Might just help to clarify this by being consistent.

cfdreddbot commented 6 years ago

Hey williammartin!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

duglin commented 6 years ago

should we be really explicit and make it X-Broker-API-Originating-Identity ?

williammartin commented 6 years ago

Yeh, I was wondering whether we should do that or have a section on headers in the specification that they all start with X-Broker-API, then we could miss out the prefix in other places. Happy to fix the PR with either.

duglin commented 6 years ago

For now, let's just take the easy path and use the actual header name

williammartin commented 6 years ago

Cool, fixed up.

duglin commented 6 years ago

Speedy! Thanks! LGTM

Approved with PullApprove

pmorie commented 6 years ago

LGTM

Approved with PullApprove

duglin commented 6 years ago

one more review needed