search

openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 434 forks source link

add colon(:) #575

Closed yancai closed 6 years ago

yancai commented 6 years ago

fix #569

cfdreddbot commented 6 years ago

Hey yancai!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please have everyone sign the appropriate CLA (individual or corporate), and send to: contributors@cloudfoundry.org.

When sending a signed CLA please provide your github username in case of an individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

The following github user @yancai has not signed the appropriate CLA.

If you are confident that everyone listed is covered under a Corporate CLA, please make sure everyone has publicized their membership in the appropriate Github Org, per these instructions.

Once everyone has publicized their membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

duglin commented 6 years ago

LGTM once CLA is done

Approved with PullApprove

mattmcneeney commented 6 years ago

@yancai Please could you sign the CLA and then let us know? I can then close and reopen this PR. PMC members should hold off approving this for now as we will have to do it again.

duglin commented 6 years ago

@yancai can you please sign the CLA? If not someone else can do this fix for you - just let us know

yancai commented 6 years ago

@duglin Sorry, I am currently on a business trip until July 23. I can't sign the CLA now. If you want to fix this urgently, you can find someone else to fix this bug.

duglin commented 6 years ago

No, I don't think its urgent, we can wait - thanks for the update

yancai commented 6 years ago

@duglin I have signed CLA and sent to contributors@cloudfoundry.org

duglin commented 6 years ago

@yancai thanks!

cfdreddbot commented 6 years ago

Hey yancai!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please have everyone sign the appropriate CLA (individual or corporate), and send to: contributors@cloudfoundry.org.

When sending a signed CLA please provide your github username in case of an individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

The following github user @yancai has not signed the appropriate CLA.

If you are confident that everyone listed is covered under a Corporate CLA, please make sure everyone has publicized their membership in the appropriate Github Org, per these instructions.

Once everyone has publicized their membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

duglin commented 6 years ago

really easy review! 3 more needed

cfdreddbot commented 6 years ago

Hey yancai!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

mattmcneeney commented 6 years ago

CLA signing success!