mattmcneeney
commented
6 years ago Some other thoughts:
- What if a GET call returns 5xx? I don't think we want to orphan mitigate in that scenario.
- We should be clearer that a 5xx on a binding create should not result in orphan mitigating the underlying instance.
- In CF, we don't try to orphan mitigate on a 5xx response.
Right now the spec says:
Unless otherwise specified, an HTTP status code in the 4xx range MUST result in the Service Broker's resources being semantically unchanged as a result of the incoming request message. Additionally, an HTTP status code in the 5xx range SHOULD result in the Service Broker's resources being semantically unchanged as a result of the incoming request message. Note, the 5xx error case is a "SHOULD" instead of a "MUST" because it might not be possible for a Service Broker to guarantee that it can revert all possible effects of a failed attempt at the requested operation.
Which I think it 100% correct, in theory. However we then also have text (like the orphan mitigation section, and the async response section) which clearly states that in the event of a 5xx being sent back the Platform needs to assume the worst and delete the resource in question. This makes the "SHOULD in
an HTTP status code in the 5xx range SHOULD result in the Service Broker's resources being semantically unchangedpretty pointless, since we're just going to delete it anyway.I'm now wondering if we should just delete the "5xx... SHOULD..." sentences in the paragraph I quotes above, to avoid confusion.
What do people think?