openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 433 forks source link

Service Specific Async Provision Timeout #625

Closed cholick closed 5 years ago

cholick commented 5 years ago

Problem

Right now, the platform is responsible for deciding the timeout of service instance creation. This results in the platform choosing a very high value, to support any and all service that might be imagined. Cloud Foundry, for example, uses the value of 7 days (I imagine is to support a broker with a literal human on the other side of the broker API, a service that generated tickets?). Platforms using a value this high means that service provisioners will likely give up, and kill provisioning, long before a week has passed (assuming they have sufficient permissions). In cloud foundry, this means resorting to actions purge-service-instance.

As a service author, I'm often in a much better position to decide what that timeout value should be. For many services, values as short as an hour would be appropriate.

Suggested Solution

cholick commented 5 years ago

I haven't mentioned async binding, as I haven't really seen a problem there in practice, but that's likely because the feature is newer. In the interest of completeness, it might make sense to include a value for that as well?

duglin commented 5 years ago

I like the idea of providing this hint to the platform since, as you said, not all service brokers will have the same timeout window.

duglin commented 5 years ago

Would you be willing to submit a PR? :-)

cholick commented 5 years ago

Sure, happy to submit a PR.