search

openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 436 forks source link

Allow Service Brokers to indicate the state of a Service Instance after a failed update or deprovisioning #637

Open fmui opened 5 years ago

fmui commented 5 years ago

When an instance update or delete fails, the platform doesn't know the state of the instance and doesn't know if the operation can be repeated. This PR allows brokers to provide this additional information to the platform in case of a failure.

This PR replaces PR #570.

cfdreddbot commented 5 years ago

:white_check_mark: Hey fmui! The commit authors and yourself have already signed the CLA.

fmui commented 5 years ago

@georgi-lozev I agree. The right approach would be to return these states in the response of the fetch endpoint. But there are brokers that cannot provide a fetch endpoint. The only way I can think of that works for all brokers to transport this information is the error response. Do you have a better idea?

jberkhahn commented 5 years ago

This seems reasonable from a k8s perspective. We'd have to plumb this through to our controller, but most of these values already have corresponding values in our reconciliation logic that these could be plugged into

tinygrasshopper commented 5 years ago

Thinking a bit more about this, I think this PR does 3 things:

A comment on Feature 3: Are we are exposing the complexity of the retrying mechanism at two places in the spec, which I think is unnecessary. I think broker authors can leverage the existing Retry-After header to signify that the operation is still in progress today.

Today retry of an update can be encapsulated in the Last Operation invocation: now

Where as after this PR, in addition to the above mechanism broker authors will also have the ability to retry the update itself: after

What are the benefits of introducing an alternate mechanism for retry? Can we achieve the same result by adding the health/usability indicator to last operation?

mattmcneeney commented 4 years ago

@fmui Do we still need this PR?