Should we add Swagger/OpenAPI testing into our CI?

openservicebrokerapi / servicebroker

Open Service Broker API Specification

https://openservicebrokerapi.org/

Apache License 2.0

1.19k stars 436 forks source link

Should we add Swagger/OpenAPI testing into our CI? #664

Closed mattmcneeney closed 5 years ago

mattmcneeney commented 5 years ago

What is the problem? As demonstrated by #662, it is possible for PRs to inadvertently break our swagger/openAPI docs today as we do not check these in Travis CI. This isn't good for folks relying on these tools.

Who does this affect? Maintainers of this repo.

Do you have any proposed solutions? We could add a step to our CI pipeline to check these files for errors.

leonwanghui commented 5 years ago

@mattmcneeney This issue should be closed since it's resolved by #666

mattmcneeney commented 5 years ago

Good spot - thanks @leonwanghui !