Specify that Platforms SHOULD NOT reuse IDs

openservicebrokerapi / servicebroker

Open Service Broker API Specification

https://openservicebrokerapi.org/

Apache License 2.0

1.19k stars 436 forks source link

Specify that Platforms SHOULD NOT reuse IDs #681

Closed mattmcneeney closed 5 years ago

mattmcneeney commented 5 years ago

What is the problem this PR solves? Closes #447

Checklist:

[x] The swagger.yaml doc has been updated with any required changes
[x] The openapi.yaml doc has been updated with any required changes

cfdreddbot commented 5 years ago

:white_check_mark: Hey mattmcneeney! The commit authors and yourself have already signed the CLA.

fmui commented 5 years ago

This PR conflicts with PR #680. If the ID can be reused, which state should last_operation return?

mattmcneeney commented 5 years ago

I think that same logic could apply elsewhere in the spec (fetching an instance maybe?), but the mitigation here is that there is an operation field which could be used to reference a specific operation.

mattmcneeney commented 5 years ago

We discussed this on today's call, and we concluded that we don't believe Platforms should reuse IDs. Some brokers wouldn't support this anyway, and in reality it seems very unlikely to happen since both CF and svc-cat generate a new GUID for each service instance.

Our options:

Close this PR and do nothing about this
Change the spec to say that platforms SHOULD NOT reuse IDs, and advise brokers what they should do in case that does happen

mattmcneeney commented 5 years ago

Review please @jberkhahn @tinygrasshopper