osb-checker seems written in JS not in golang

openservicebrokerapi / servicebroker

Open Service Broker API Specification

https://openservicebrokerapi.org/

Apache License 2.0

1.19k stars 436 forks source link

osb-checker seems written in JS not in golang #692

Closed felixfriedrich closed 4 years ago

felixfriedrich commented 5 years ago

What is the problem this PR solves? The description mentioned the wrong language being used.

cfdreddbot commented 5 years ago

:white_check_mark: Hey felixfriedrich! The commit authors and yourself have already signed the CLA.

leonwanghui commented 4 years ago

Hi, the golang code is currently located in dev branch, and it has supported for v2.14 spec with MVP

felixfriedrich commented 4 years ago

@leonwanghui The dev branch doesn't seem to be public.

leonwanghui commented 4 years ago

@felixfriedrich Yes currently the default branch is master branch, but we are planning to merge dev branch into master branch, and by then you will see the golang project.

leonwanghui commented 4 years ago

@mattmcneeney I'm afraid that it can't not be merged directly because of commits difference, do you have some suggestion? Thanks!

mattmcneeney commented 4 years ago

@leonwanghui We can probably move the lastest master to a backup branch and then reset it to point at the top of the dev branch. Is the dev branch ready to be master?

mattmcneeney commented 4 years ago

@leonwanghui What do you think of the above idea?

leonwanghui commented 4 years ago

@mattmcneeney I think it's ready, if anyone others has no opinion, please do it : )

mattmcneeney commented 4 years ago

@leonwanghui I've updated the master branch with what was on dev and created a backup branch!

That means the master of osb-checker is written in golang and we can close this PR