search

openservicebrokerapi / servicebroker

Open Service Broker API Specification
https://openservicebrokerapi.org/
Apache License 2.0
1.19k stars 436 forks source link

remove Object type declaration and references from swagger.yaml #696

Closed jberkhahn closed 4 years ago

jberkhahn commented 4 years ago

What is the problem this PR solves? This PR solves issue #693. The declaration of an "Object" type was causing problems in languages such as Java by overwriting the normal Object type. I've removed the declaration in the swagger.yaml which was included for deduplication purposes, and inlined references to the default object type.

Checklist:

linux-foundation-easycla[bot] commented 4 years ago

CLA Check
The committers are authorized under a signed CLA.

jberkhahn commented 4 years ago

Uh, when did the CLA stuff get moved around? I clicked-through and followed the instructions for contributors who were previously authorized, and it's telling me my email is not in the list of previously approved contributors?

mattmcneeney commented 4 years ago

@jberkhahn I know the CFF recently changed CLA bots - so this could be a fall out from that. Are you happy to sign the new one or do you want me to try to find some more info on this?

jberkhahn commented 4 years ago

I tried to sign the new one by claiming I worked for IBM, and it didn't accept that either :/

mattmcneeney commented 4 years ago

Looking into this now...

chipchilders commented 4 years ago

@jberkhahn try selecting "CFF Migration" as the name of your company... if that doesn't get you through the flow, can you please get in contact with the Linux Foundation support team via: https://jira.linuxfoundation.org/servicedesk/customer/portal/4 and select Get Help with Easy CLA.

If that fails, ping me again and I'll escalate it within LF.

WillsonHG commented 4 years ago

@jberkhahn @chipchilders I believe I may have fixed the issue with the EasyCLA bot for your PR. Jonathan, can you please try again to sign by selecting "Corporate" and then select "CFF Migration" from the list of companies. You should be white listed now and be presented with a box to check for verification. If after you are able to do this and the CLA status doesn't update after a page refresh, you can try closing and reopening this pr to retrigger the check. Hopefully this works, and sorry for all the trouble.

jberkhahn commented 4 years ago

Well I'm now getting a new error. It went from saying my email wasn't listed to "Unfortunately, you are not yet whitelisted by the Corporation CLA of CFF Migration on Cloud Foundry Foundation".

WillsonHG commented 4 years ago

@jberkhahn Thanks for reporting back. I'll look into this new error for you now.

WillsonHG commented 4 years ago

@jberkhahn Okay, please try one more time. Do the same above steps, select Corporate --> CFF Migration and see if that gets you in now.

jberkhahn commented 4 years ago

pew pew pew! thanks @WillsonHG

WillsonHG commented 4 years ago

@jberkhahn you're welcome! I'm glad it finally worked :)