search

openservicemesh / osm-docs

a docs page for open service mesh
https://docs.openservicemesh.io
Apache License 2.0
4 stars 40 forks source link

demo: update the traffic split docs to meet expectations for root services #423

Closed jsturtevant closed 2 years ago

jsturtevant commented 2 years ago

Signed-off-by: James Sturtevant jstur@microsoft.com

When running the demo at https://release-v1-2.docs.openservicemesh.io/docs/getting_started/traffic_split/#deploy-bookstore-v2-application even though the docs state: The counter should not be incrementing because no traffic is flowing yet to the bookstore-v2 service.

I was seeing traffic flow. This was because the Kubernetes service was selecting all pods with the label app: bookstore ~where as it should have been selecting just v1.~ as it was the root service.

This is a follow up to https://github.com/openservicemesh/osm-docs/pull/413 where this change was initially made

netlify[bot] commented 2 years ago

Deploy Preview for osm-docs ready!

Name Link
Latest commit a49d9c85cee11636e39636bbfc1894395e13614c
Latest deploy log https://app.netlify.com/sites/osm-docs/deploys/62e08235f0ed940008759ee7
Deploy Preview https://deploy-preview-423--osm-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

shashankram commented 2 years ago

@mergifyio backport release-v1.2