Closed jsturtevant closed 1 year ago
Merging #5258 (97a724c) into main (8d92d3d) will decrease coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #5258 +/- ##
==========================================
- Coverage 69.45% 69.44% -0.01%
==========================================
Files 198 198
Lines 16041 16041
==========================================
- Hits 11141 11140 -1
- Misses 4843 4844 +1
Partials 57 57
Flag | Coverage Δ | |
---|---|---|
unittests | 69.44% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/messaging/workqueue.go | 89.28% <0.00%> (-10.72%) |
:arrow_down: |
pkg/certificate/manager.go | 86.97% <0.00%> (-0.43%) |
:arrow_down: |
pkg/ticker/ticker.go | 86.66% <0.00%> (+4.00%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
As a note, it looks like tests in bucket 11 still take 30 minutes to complete.
I moved "can switch providers during rotation" to its own bucket. That test takes awhile since it install cert-manager.io and vault then rotates from tresor-> cert-manager -> vault -> tresor
we are down to 21m which is on par with other tests
Signed-off-by: James Sturtevant jstur@microsoft.com
Description: Split e2es into more buckets so overall time for test completion is faster. fixes: #5257
Testing done:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?