openservicemesh / osm

Open Service Mesh (OSM) is a lightweight, extensible, cloud native service mesh that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
https://openservicemesh.io/
Apache License 2.0
2.59k stars 277 forks source link

Split e2es into more buckets #5258

Closed jsturtevant closed 1 year ago

jsturtevant commented 1 year ago

Signed-off-by: James Sturtevant jstur@microsoft.com

Description: Split e2es into more buckets so overall time for test completion is faster. fixes: #5257

Testing done:

Affected area: Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

codecov-commenter commented 1 year ago

Codecov Report

Merging #5258 (97a724c) into main (8d92d3d) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5258      +/-   ##
==========================================
- Coverage   69.45%   69.44%   -0.01%     
==========================================
  Files         198      198              
  Lines       16041    16041              
==========================================
- Hits        11141    11140       -1     
- Misses       4843     4844       +1     
  Partials       57       57              
Flag Coverage Δ
unittests 69.44% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/messaging/workqueue.go 89.28% <0.00%> (-10.72%) :arrow_down:
pkg/certificate/manager.go 86.97% <0.00%> (-0.43%) :arrow_down:
pkg/ticker/ticker.go 86.66% <0.00%> (+4.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jsturtevant commented 1 year ago

As a note, it looks like tests in bucket 11 still take 30 minutes to complete.

I moved "can switch providers during rotation" to its own bucket. That test takes awhile since it install cert-manager.io and vault then rotates from tresor-> cert-manager -> vault -> tresor

jsturtevant commented 1 year ago

we are down to 21m which is on par with other tests