openservicemesh / osm

Open Service Mesh (OSM) is a lightweight, extensible, cloud native service mesh that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
https://openservicemesh.io/
Apache License 2.0
2.59k stars 277 forks source link

OSM v1.2 Upgrade not working for CRD schema changes due to reconciler. #5259

Closed nshankar13 closed 1 year ago

nshankar13 commented 1 year ago

Bug description:

When upgrading from v1.1.1 (or any previous version of OSM that doesn't have the httpRoutes field in the UpstreamTrafficSetting CRD -> v1.2.2 with enableReconciler: true set upon both installation and upgrades (ex: osm mesh upgrade --set ...), the CRD schema change is not persisting - when testing locally, the osm bootstrap pod logs (via local dev version of osm-bootstrap I configured) outputs the correct schema when updating the spec. However, it seems like the reconciler is reverting the UpstreamTrafficSetting back to the previous v1.1.1 version and removing the httpRoutes field. This causes OSM v1.2.2 to fail the ratelimit e2e test, as ratelimit configurations are done via setting the httpRoutes spec in the Upstream Traffic Setting.

Affected area (please mark with X where applicable):

Expected behavior: UpstreamTrafficSetting for v1.2 should still have the httpRoutes field when upgrading from v1.1 -> v1.2 with the reconciler enabled.

Steps to reproduce the bug (as precisely as possible):

How was OSM installed?:

Anything else we need to know?:

Bug report archive:

Environment:

github-actions[bot] commented 1 year ago

This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update.

github-actions[bot] commented 1 year ago

Issue closed due to inactivity.