openservicemesh / osm

Open Service Mesh (OSM) is a lightweight, extensible, cloud native service mesh that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
https://openservicemesh.io/
Apache License 2.0
2.59k stars 277 forks source link

Removed deprecated functionality #5296

Closed mudit-01 closed 1 year ago

mudit-01 commented 1 year ago

Removed Go 1.16 functionality of io/ioutil that is deprecated now.

Signed-off-by: mudit singh mudit.singh@india.nec.com

Description:

Testing done: Yes

Affected area: Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [X ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

codecov-commenter commented 1 year ago

Codecov Report

Merging #5296 (3ea8159) into main (d6a8817) will decrease coverage by 0.05%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #5296      +/-   ##
==========================================
- Coverage   69.52%   69.47%   -0.05%     
==========================================
  Files         197      197              
  Lines       16071    16071              
==========================================
- Hits        11173    11165       -8     
- Misses       4841     4849       +8     
  Partials       57       57              
Flag Coverage Δ
unittests 69.47% <ø> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mudit-01 commented 1 year ago

Hi @keithmattix @jaellio the lint error is showing in the files that are unchanged by me is there any upgrade in the lint checker?

mudit-01 commented 1 year ago

@trstringer @keithmattix @jaellio PTAL waiting for your review

mudit-01 commented 1 year ago

Thanks! @keithmattix