openservicemesh / osm

Open Service Mesh (OSM) is a lightweight, extensible, cloud native service mesh that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
https://openservicemesh.io/
Apache License 2.0
2.58k stars 277 forks source link

fix(): remove support for incompatible tls versions for envoy TLSMaxProtocolVersion #5298

Closed whitneygriffith closed 1 year ago

whitneygriffith commented 1 year ago

Description: Part of #5282. This removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options.

Testing done:

Affected area: Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [x]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [x]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]
codecov-commenter commented 1 year ago

Codecov Report

Merging #5298 (c3f6032) into release-v1.2 (1a9b067) will decrease coverage by 0.02%. The diff coverage is n/a.

:exclamation: Current head c3f6032 differs from pull request most recent head e57e7d2. Consider uploading reports for the commit e57e7d2 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@               Coverage Diff                @@
##           release-v1.2    #5298      +/-   ##
================================================
- Coverage         68.83%   68.81%   -0.02%     
================================================
  Files               210      210              
  Lines             15679    15679              
================================================
- Hits              10792    10789       -3     
- Misses             4836     4839       +3     
  Partials             51       51              
Flag Coverage Δ
unittests 68.81% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

keithmattix commented 1 year ago

@whitneygriffith don't forget to submit a similar PR for the main branch